Re: [PATCH][1/8] Arch agnostic completely out of line locks / generic

From: Zwane Mwaikambo
Date: Thu Sep 02 2004 - 20:39:45 EST


On Thu, 2 Sep 2004, Linus Torvalds wrote:

> On Thu, 2 Sep 2004, Zwane Mwaikambo wrote:
> >
> > No real reason, i have a habit of never specifying the section in the
> > definition. The following simply moves __lockfunc into spinlock.h and
> > uses it everywhere.
>
> Ok, I'm happy with this. I'll even apply it if you make a version relative
> to my -BK tree ;).

Great, i'll merge.

> Btw, there must be something wrong in your size comparison for x86:
>
> i386 = 524115 bytes
> text data bss dec hex filename
> 5695619 870906 328112 6894637 69342d vmlinux-after
> 6221254 870634 326864 7418752 713380 vmlinux-before
>
> The "bss" number shouldn't change as far as I can tell, and indeed, on all
> the other architectures you cite, it doesn't change. So I think your
> before/after numbers on x86 are something else.

i386 = 416075 bytes
text data bss dec hex filename
5808371 867442 326864 7002677 6ada35 vmlinux-after
6221254 870634 326864 7418752 713380 vmlinux-before

Those seem to make a lot more sense.

Thanks,
Zwane
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/