Re: [PATCH] 2.6.8.1 ES7000 subarch update

From: Alan Cox
Date: Fri Sep 03 2004 - 07:28:08 EST


On Gwe, 2004-09-03 at 00:52, Jason Davis wrote:
> int mip_port;
> unsigned long mip_addr, host_addr;
>
> +EXPORT_SYMBOL(mip_reg);
> +EXPORT_SYMBOL(host_reg);
> +EXPORT_SYMBOL(mip_port);
> +EXPORT_SYMBOL(mip_addr);
> +EXPORT_SYMBOL(host_addr);

This is asking for collisions with other modules. It would be a lot
better for the future it these became e7000_mip_reg etc I think.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/