hpt366 ptr use before NULL check.

From: Dave Jones
Date: Fri Sep 03 2004 - 16:24:49 EST


Another picked up with the coverity checker.

Signed-off-by: Dave Jones <davej@xxxxxxxxxx>

--- linux-2.6.8/drivers/ide/pci/hpt366.c~ 2004-09-03 22:13:46.870500672 +0100
+++ linux-2.6.8/drivers/ide/pci/hpt366.c 2004-09-03 22:14:53.095432952 +0100
@@ -773,13 +773,17 @@
static int hpt3xx_tristate (ide_drive_t * drive, int state)
{
ide_hwif_t *hwif = HWIF(drive);
- struct pci_dev *dev = hwif->pci_dev;
- u8 reg59h = 0, reset = (hwif->channel) ? 0x80 : 0x40;
- u8 regXXh = 0, state_reg= (hwif->channel) ? 0x57 : 0x53;
+ struct pci_dev *dev;
+ u8 reg59h = 0, reset;
+ u8 regXXh = 0, state_reg;

if (!hwif)
return -EINVAL;

+ dev = hwif->pci_dev;
+ reset = (hwif->channel) ? 0x80 : 0x40;
+ state_reg = (hwif->channel) ? 0x57 : 0x53;
+
// hwif->bus_state = state;

pci_read_config_byte(dev, 0x59, &reg59h);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/