Re: [PATCH 4/5][RFC] fbdev: Clean up framebuffer initialization

[Antonino A. Daplas]

On Saturday 04 September 2004 11:36, Thomas Winischhofer wrote:
> > 5. Because driver initialization will be dependent on the link order,
> > hardware that depends on other subsystems (agpgart, usb, serial, etc) may
> > choose to initialize after the subsystems they depend on.
> >
> > Signed-off-by: Antonino Daplas <adaplas@xxxxxxx>
>
> I don't really see a benefit but it's ok with me.
>

Mainly cleanup, but also point #5.  The i810fb, for instance, depends on agpgart, but
agpgart gets initialized way after fbdev.  The workaround is for i810fb to explicitly
call intel_agp_init().  Besides the ugliness, forcibly initializing the agpgart subsystem
out of sequence may cause problems.

With this change, in theory, I can move i810fb's link order so it gets initialized after
agpgart.

> (Thanks for considering the "unified" nature of sisfb, by the way. Very
> considarate. Very much appreciated.)
>
> I assume that you tested this stuff before posting it here.

Yes, with hardware that I have.  I did try to at least compile test what I can.

Tony


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/