Re: [RFC/patch] macro_removal_agp_mtrr.diff

From: Arjan van de Ven
Date: Sat Sep 04 2004 - 08:32:44 EST


On Sat, Sep 04, 2004 at 02:23:30PM +0100, Dave Airlie wrote:
>
> Okay here is an updated patch:
>
> I've taken suggestions from Christoph and Arjan on board,
>
> My only issue is with the stuff in drm_os_linux.h, I've had to make a
> dummy AGP structure, and add the mtrr_add/mtrr_del stubs (as they are fine
> on x86 but don't exist on anything else..) but perhaps a small ugly in
> there is better than big uglies elsewhere...

I like it


> I might be able to drop the OS_HAS_AGP from the drivers, but that'll be a
> job that requires testing via CVS (as that is where we have the people
> with the different cards..)

well Rome wasn't built on one day either; this sure is a step in the right
direction.

Attachment: pgp00000.pgp
Description: PGP signature