Re: [PATCH 2.6.9-rc1-mm3] [m32r] Change from EXPORT_SYMBOL_NOVERS to EXPORT_SYMBOL

[Sam Ravnborg]

On Mon, Sep 06, 2004 at 09:55:12PM +0900, Hirokazu Takata wrote:
> Hi, 
> 
> From: Zwane Mwaikambo <zwane@xxxxxxxxxxxxx>
> Subject: Re: 2.6.9-rc1-mm3
> Date: Fri, 3 Sep 2004 08:48:27 -0400 (EDT)
> > Just a few comments.
> Thank you.
> 
> > - There appears to be yet another smc 91C111 driver in there, Takata,
> >   there should be a unified one in drivers/net/smc91x.c.
> Yes.  I would like to use drivers/net/smc91x.c.  Now investigating it...
> 
> > - arch/m32r/Kconfig could do with some trimming.
> Yes.  I am going to clean up it.
> 
> > - arch/m32r/kernel/irq.c shows that we really could do with that irq
> >   consolidation.
> I see.  Some i386 code and comments are remained in there.
> 
> > - arch/m32r/kernel/m32r_ksyms, EXPORT_SYMBOL_NOVERS is deprecated, use
> >   EXPORT_SYMBOL.
> Here is a patch for that.
> 
> Signed-off-by: Hirokazu Takata <takata@xxxxxxxxxxxxxx>
> 
> 
> diff -rup linux-2.6.9-rc1-mm3.orig/arch/m32r/kernel/m32r_ksyms.c linux-2.6.9-rc1-mm3/arch/m32r/kernel/m32r_ksyms.c
> --- linux-2.6.9-rc1-mm3.orig/arch/m32r/kernel/m32r_ksyms.c	2004-09-03 20:46:13.000000000 +0900
> +++ linux-2.6.9-rc1-mm3/arch/m32r/kernel/m32r_ksyms.c	2004-09-06 17:12:18.000000000 +0900
> @@ -48,9 +48,9 @@ EXPORT_SYMBOL(__udelay);
>  EXPORT_SYMBOL(__delay);
>  EXPORT_SYMBOL(__const_udelay);
>  
> -EXPORT_SYMBOL_NOVERS(__get_user_1);
> -EXPORT_SYMBOL_NOVERS(__get_user_2);
> -EXPORT_SYMBOL_NOVERS(__get_user_4);
> +EXPORT_SYMBOL(__get_user_1);
> +EXPORT_SYMBOL(__get_user_2);
> +EXPORT_SYMBOL(__get_user_4);
......

The convention these days is to put the EXPORT right uder the funtion definition
when appropriate.

So something like:
int foo(int l)
{
	...
}
EXPORT_SYMBOL(foo);

No one just took their time to get rid of the rest of the *ksyms files.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/