Re: [PATCH 1/3] copyfile: generic_sendpage

[Jörn Engel]

On Tue, 7 September 2004 13:48:54 +0200, Gunnar Ritter wrote:
> Jörn Engel <joern@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > Add another loop in the userspace caller to deal with it, if you don't
> > already have it. It's a valid and documented return value, after all.
> 
> Of course (although cp will be terminated by the SIGINT anyway, so it
> does not matter in this situation).

I tested by hitting Ctrl-z.  My admittedly stupid test program didn't
have a loop, so the fg terminated it. :)

> Do I understand this correctly that sendfile now behaves like write with
> SA_RESTART not set for the signal?

Yes.

> If so, it might perhaps make sense to
> add SA_RESTART semantics too, so that sendfile then just continues if the
> process catches the signal and does not abort (scenario: SIGWINCH is sent
> to a curses-based file manager).

It might, not sure.  I've never actually looked at it, never missed
it, don't need it.  Maybe someone else has a strong feeling one way or
the other?

Jörn

-- 
He who knows others is wise.
He who knows himself is enlightened.
-- Lao Tsu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/