Re: [PATCH 4/4] copyfile: copyfile

[Linus Torvalds]

On Tue, 7 Sep 2004, Jörn Engel wrote:

> On Tue, 7 September 2004 07:06:00 -0700, Linus Torvalds wrote:
> > 
> > Then you could (and should) make a "generic_file_copy()" function that
> > takes that pathname format, and then uses sendfile() to do the copy for
> > regular disk-based filesystems.
> 
> Does that mean that you're ok with the first three patches?

No, it means that they weren't fundamentally flawed..

Actually, the 4kB batching one was - if you only max out to using 4kB at a 
time, sendfile() is kind of pointless, because then it will never do 
multi-page copies in the first place, and all the complexity at a lower 
level is worthless..

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/