Re: [PATCH] missing pci_disable_device()

[Kenji Kaneshige]

Alan Cox wrote:

> On Maw, 2004-09-07 at 02:26, Kenji Kaneshige wrote:
>> Hi,
>> 
>> As mentioned in Documentaion/pci.txt, pci device driver should call
>> pci_disable_device() to deallocate any IRQ resources, disable PCI
>> bus-mastering and etc. when it decides to stop using the device.
>> But there seems to be many drivers that don't use pci_disable_device()
>> properly so far.
> 
> Think about unloading frame buffers or PCI devices with multiple
> functions and multiple drivers. I agree the drivers definitely want
> fixing where appropriate. I'm not sure your approach is safe (although a

I don't understand what you are worried about. Could you tell me
what would be a problem with frame buffers or PCI devices with
multiple functions?

> debug printk would work wonders perhaps ?)

Exactly. I think debug printk is more important because what we
really need is fixing all broken drivers which don't call
pci_disable_device().

Thanks,
Kenji Kaneshige


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/