Re: 2.6.9-rc1-bk16: DHCPACK, compile time error ...

[David S. Miller]

On Thu, 9 Sep 2004 16:14:04 +0200
Herbert Poetzl <herbert@xxxxxxxxxxxx> wrote:

> net/ipv4/ipconfig.c:969: error: `i' undeclared (first use in this function)
> net/ipv4/ipconfig.c:969: error: (Each undeclared identifier is reported only once
> net/ipv4/ipconfig.c:969: error: for each function it appears in.)

Already fixed in my tree like so, on it's way to Linus:

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/09/08 17:38:20-07:00 peter@xxxxxxxxxxxx 
#   [IPV4]: Fix DHCPACK checking in ipconfig.c
#   
#   Signed-off-by: Peter Buckingham <peter@xxxxxxxxxxxx>
#   Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
# 
# net/ipv4/ipconfig.c
#   2004/09/08 17:37:44-07:00 peter@xxxxxxxxxxxx +1 -3
#   [IPV4]: Fix DHCPACK checking in ipconfig.c
# 
diff -Nru a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
--- a/net/ipv4/ipconfig.c	2004-09-09 08:31:35 -07:00
+++ b/net/ipv4/ipconfig.c	2004-09-09 08:31:35 -07:00
@@ -966,9 +966,7 @@
 				break;
 
 			case DHCPACK:
-				for (i = 0; (dev->dev_addr[i] == b->hw_addr[i])
-						&& (i < dev->addr_len); i++);
-				if (i < dev->addr_len)
+				if (memcmp(dev->dev_addr, b->hw_addr, dev->addr_len) != 0)
 					goto drop_unlock;
 
 				/* Yeah! */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/