Re: 2.6.9-rc1-bk15: kernel BUG at net/ipv4/tcp_output.c:271!

[David S. Miller]

On Thu, 9 Sep 2004 12:02:28 +0000 (UTC)
"Miquel van Smoorenburg" <miquels@xxxxxxxxxx> wrote:

> I tried 2.6.9-rc1-bk15 on one of my servers, and it soon crashes
> with "kernel BUG at net/ipv4/tcp_output.c:271!". 2.6.9-rc1
> is fine. Line 271 is
> 
> 	BUG_ON(!TCP_SKB_CB(skb)->tso_factor);
> 
> .. it appears that the tso_factor stuff was added somewhere
> after 2.6.9-rc1.

Thanks for the report (although please use netdev@xxxxxxxxxxx
next time).  The patch below should fix it.

===== net/ipv4/tcp_output.c 1.52 vs edited =====
--- 1.52/net/ipv4/tcp_output.c	2004-09-09 08:37:00 -07:00
+++ edited/net/ipv4/tcp_output.c	2004-09-09 08:47:27 -07:00
@@ -434,7 +434,7 @@
 		unsigned int factor;
 
 		factor = skb->len + (mss_std - 1);
-		factor /= mss;
+		factor /= mss_std;
 		TCP_SKB_CB(skb)->tso_factor = factor;
 	}
 }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/