Re: [PATCH] ppc: fix sungem NAPI

[David S. Miller]

On Fri, 10 Sep 2004 13:49:17 +1000
Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:

> The recent sungem NAPI change introduced a bug: dev_kfree_skb() is called
> within the spinlock, thus triggers all sort of WARN_ON's later on down the
> stack.
> 
> This patch changes it to dev_kfree_skb_any(), I hope that is fine
> as we aren't really in interrupt, are we ? (I don't know in what
> context NAPI polling occurs, is it a timer IRQ ?)

NAPI polling occurs from softirq context.

Thanks for making me aware of this.  This fix is fine for
now, but it may be possible to simplify it and I'll look
into that.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/