Re: 2.6.9-rc1-mm4 badness in rtl8150.c ethernet driver : fixed

[Petko Manolov]

On Thu, 9 Sep 2004, Greg KH wrote:

> On Thu, Sep 09, 2004 at 03:24:54PM -0700, Andrew Morton wrote:
> > Eric Valette <eric.valette@xxxxxxx> wrote:
> > > Here is a small patch that makes the card functionnal again. I've
> > > forwarded the patch to driver author also.
> > >
> > > --- linux/drivers/usb/net/rtl8150.c-2.6.9-rc1-mm4.orig	2004-09-09 11:15:11.000000000 +0200
> > > +++ linux/drivers/usb/net/rtl8150.c	2004-09-09 11:15:46.000000000 +0200
> > > @@ -341,7 +341,7 @@
> > >
> > >  static int rtl8150_reset(rtl8150_t * dev)
> > >  {
> > > -	u8 data = 0x11;
> > > +	u8 data = 0x10;
> >
> > hm, OK.  Presumably the change (which comes in via the bk-usb tree) was
> > made for a reason.  So I suspect both versions are wrong ;)
> >
> > But it might be risky for Greg to merge this patch up at present.
>
> As all your patch does is revert the patch in my tree (it was a one line
> change), mainline should work just fine for you, right?
>
> I'll defer to Petkan as to what to do about this, as he sent me that
> patch for a good reason I imagine :)

Steven Hein <ssh@xxxxxxx> sent me a patch that supposedly fix device 
registers misinitialization when it is being frequently reseted.

RTL8150 is quite flaky piece of HW so i first tested the new value and it 
did work for me.  That's why i decided to send it to Greg.

I would say lets wait for some time and see if we'll break someone else's
heart and then reverse the patch.  Another solution is to restore the 
original value and add new module parameter, so whoever thinks
anything != 0x10 work better for him will be free to change it.


		Petko
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/