Re: [PATCH] exec: fix posix-timers leak and pending signal loss

From: Andrew Morton
Date: Mon Sep 13 2004 - 19:34:29 EST


Roland McGrath <roland@xxxxxxxxxx> wrote:
>
> Frankly, I think the old code is much more prone to unforeseen problems
> than the new.

It's a question of testing coverage, and historical fragility of that part
of the code. I'm uncomfortable making changes in there unless we're early
in the release cycle.

> > Had you not rolled three distinct patches into one (hint) I'd have
> > forwarded along the leak fix and sat on the rest for post-2.6.9.
>
> I don't like being an enabler of bad code. So I didn't do a separate fix
> inside something that I already knew needed to be ripped out. If you want
> an untested minimal fix for just the leak potential, leaving the semantics
> frotzed in multiple ways

As long as "frotzed" != "goes oops mysteriously two days after we release
2.6.9" I'm happy.

> you can try the following.

I shall, thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/