Re: [no patch] broken use of mm_release / deactivate_mm

From: Andries Brouwer
Date: Tue Sep 14 2004 - 18:28:25 EST


On Tue, Sep 14, 2004 at 08:06:14AM -0700, Linus Torvalds wrote:

> Does everybody also agree that ... mmput() does all of that correctly too?

I think so, but do not have time to check all details.


Now the first parameter of mm_release() always is current,
so that this parameter is superfluous. Similarly, the only
parameter of exit_mm() always is current, and hence is superfluous.

Maybe it is a good idea to remove the pretense that these routines
might do something useful for general parameters, now that
deactivate_mm() does sneaky global things.

Andries

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/