Re: review MPSC driver

From: Adrian Bunk
Date: Thu Sep 16 2004 - 03:12:39 EST


On Wed, Sep 15, 2004 at 09:43:01PM -0700, Randy.Dunlap wrote:
>
> | http://www.uwsg.iu.edu/hypermail/linux/kernel/0408.3/1549.html
>
> Hi Mark,
>...
> 3. + select SERIAL_CORE
> + select SERIAL_CORE_CONSOLE
>
> Please don't use "select". Use "depends on" instead.
>...

That's a silly suggestion since none of these options are user visible.

> ~Randy

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/