Re: [PATCH-NEW] allow root to modify raw scsi command permissionslist

[Marc Ballarin]

On Wed, 15 Sep 2004 19:36:18 -0400
Peter Jones <pjones@xxxxxxxxxx> wrote:

> Yes.
> 
> Here's another version of the patch.  It does what yours did, as well as
> that.  It also combines the read and write code so there's one of each,
> with a parameter to tell which it's supposed to modify.

Looks *slightly* better than mine ;-)

But

> +static ssize_t rcf_cmds_store(struct rawio_cmd_filter *rcf, const char *page,
> +			size_t count, int rw)
	...
> +		ss.from = (char *)page+ret;
> +		ss.to = (char *)page+ret+1;

needs to be

> +		ss.from = (char *)page+ret;
> +		ss.to = (char *)page+ret+2;

Regards
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/