Re: [RFC, 2.6] a simple FIFO implementation

From: Stelian Pop
Date: Thu Sep 16 2004 - 09:13:00 EST


On Thu, Sep 16, 2004 at 06:57:50AM -0700, Paul Jackson wrote:

> This still has a 'size' attribute. As Andrew noted,
> this might not be needed.

No, Andrew noted that 'len' was unneeded (although he talked about
'size', he really meant 'len' == the amount of data in the FIFO) (*)

> See for example:
>
> http://cse.stanford.edu/class/cs110/handouts/27Queues.pdf
>
> for coding a fifo queue with just a put and get pointer.

... and a start and a end pointer.

This is identical to my patch (minus the fact that 'start' is called
'buffer' in my patch and I have the 'size' field instead of an 'end'
pointer).
>
> The queue is empty if put == get, and it is full if adding one more
> would make it empty. The number of elements in the queue can be done
> using modulo arithmetic on the difference between put and get (or what
> the above *.pdf file and your code calls head and tail), with no
> distinct 'size' element. The head and tail wrap.

Did you read my second patch ?

Stelian.
--
Stelian Pop <stelian@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/