Re: [PATCH] BUG on fsync/fdatasync with Ext3 data=journal

[Seiji Kihara]

Hi, 

Thank you for reply, Mr. Morton.  I apologize to everyone that the
mail I sent last night was not delivered to lists because of its
size (maybe).

At Thu, 16 Sep 2004 14:50:59 -0700,
Andrew Morton wrote:
(snip)
> Yes, the I_DIRTY test is bogus because data pages are not marked dirty at
> write() time when the filesystem is mounted in data=journal mode.
> 
> However your patch will disable the above optimisation for data=writeback
> and data-ordered modes as well.  I don't think that's necessary?
> 
> How about this?

I have not understood what is the real problem yet, but I agree
that your patch is better than mine, and confirmed that no problem
occured during the test by the "diskio" and the kernel 2.6.8.1
with your patch.

Thank you again.

Seiji

-- 
Seiji Kihara
Open Source Software Computing Project,
NTT Cyber Space Laboratories, Yokosuka, JAPAN
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/