Re: [patch] remove the BKL (Big Kernel Lock), this time for real

[Linus Torvalds]

On Fri, 17 Sep 2004, Ingo Molnar wrote:
> 
> the attached patch is a simplified variant of the remove-bkl patch i
> sent two days ago: it doesnt do the ->cpus_allowed trick.
> 
> The question is, is there any BKL-using kernel code that relies on the
> task not migrating to another CPU within the BLK critical section?

I don't think there can be any _valid_ such use.

Anything that knows about CPU's has to use "get_cpu()/put_cpu()" anyway. 
You might add back in the debugging checks that we used to have for 
"smp_processor_id()" in this patch for testing, and if it goes into -mm 
we'd see if anything triggers.

I still don't exactly love this patch to death, but making the cpumask 
trickery go away does make it look a lot simpler, I have to say.

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/