Re: [PATCH][2.6][4/14] dvb core update

[Jesper Juhl]

On Fri, 17 Sep 2004, Michael Hunold wrote:

> Date: Fri, 17 Sep 2004 16:27:45 +0200
> From: Michael Hunold <hunold@xxxxxxxxxxx>
> To: Linus Torvalds <torvalds@xxxxxxxx>
> Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>,
>     Andrew Morton <akpm@xxxxxxxx>
> Subject: Re: [PATCH][2.6][4/14] dvb core update
> 
> 

[...]

> - [DVB] convert C++ comments to C comments

It seems you missed a few, and the patch adds a few itself :  
 
> @@ -662,19 +670,9 @@
>          // sanity check

[...]
 
> +				// no need to poll if the CAM supports IRQs

[...]

> +				// poll mode

[...]

>  	FE_NEEDS_BENDING              = 0x20000000, // frontend requires frequency bending
>  	FE_CAN_RECOVER                = 0x40000000, // frontend can recover from a cable unplug automatically
>  	FE_CAN_MUTE_TS                = 0x80000000  // frontend can stop spurious TS data output

And I'll bet there are probably more if I could be bothered to check the 
actual files.

Besides, didn't C99 make C++ style comments valid for C code as well?  
Does CodingStyle have any oppinion on this?


--
Jesper Juhl <juhl-lkml@xxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/