Re: [PATCH] Warn people that ipchains and ipfwadm are going away.

[Jesper Juhl]

On Wed, 22 Sep 2004, Marc Ballarin wrote:

> Date: Wed, 22 Sep 2004 15:37:07 +0200
> From: Marc Ballarin <Ballarin.Marc@xxxxxx>
> To: Patrick McHardy <kaber@xxxxxxxxx>
> Cc: davem@xxxxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, torvalds@xxxxxxxx,
>     netfilter-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] Warn people that ipchains and ipfwadm are going away.
> 
> On Wed, 22 Sep 2004 02:16:08 +0200
> Patrick McHardy <kaber@xxxxxxxxx> wrote:
> 
> > Fixed by this patch.
> 
> Yes, works fine. Does this mean that ipchains was broken for a while, but
> no one complained?
> 
> Anyway, here is another trivial patch against -bk7 that adds runtime
> warnings. IMO most users are going to miss compile time warnings, or
> won't even compile kernels themselves.
> 

I like having runtime info as well as a compile time warning, but maybe 
the message should mention that iptables is staying and people should 
migrate??

> +	printk(KERN_WARNING
> +		"Warning: ipchains is obsolete, and will be removed soon!\n");
> +			

Perhaps something like this instead:

"Warning: ipchains is obsolete, and will be removed soon. Please migrate to iptables."


--
Jesper Juhl


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/