Re: [PATCH] [PPC64] [TRIVIAL] Janitor whitespace in pSeries_pci.c

[Linas Vepstas]

On Thu, Sep 23, 2004 at 01:17:00AM +0200, Herbert Poetzl was heard to remark:
> On Tue, Sep 21, 2004 at 11:12:16AM -0500, Linas Vepstas wrote:
> > On Tue, Sep 21, 2004 at 02:07:09PM +0300, Denis Vlasenko was heard to remark:
> > > On Tuesday 21 September 2004 01:31, Linas Vepstas wrote:
> > > > 
> > > > Forgot to attach the actual patch.
> > > > 
> > > > On Mon, Sep 20, 2004 at 05:19:33PM -0500, Linas Vepstas was heard to remark:
> > > > > Hi,
> > > > 
> > > > 
> > > > This file mixes tabs with 8 spaces, leading to poor display 
> > > > if one's editor doesn't have tab-stops set to 8.   Please apply.
> > > 
> > > There are lots of such places.
> > > Automated scripts can easily produce megabytes worth of whitespace
> > > patches.
> > > 
> > > As I understand, such patches aren't accepted because
> > > merging pain is much greater than gain.
> > > Typically whitespace cleanups are piggybacked on some code changes.
> > 
> > Last time I sent in a combined whitespace plus other-fixes patch, 
> > I was asked to do the opposite, and split them apart.  I'm just
> > trying to do the right thing; I have other pending patches for this 
> > file, and I'm waiting for the backlog to clear out before I submit
> > those.
> 
> well, I'd like to know if full whitespace cleanup
> (trailing and indentation) _is_ something which
> is interesting for linux mainline ...
> 
> because if so, I probably could provide a bunch of
> patches too ... 

Hey, don't wreck it for me; I want this applied because I actually 
read this file every couple of days.  No need to clean up any files 
that *I* don't read...

--linas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/