Re: 2.6.9-rc2-mm2 fn_hash_insert oops

From: Lukas Hejtmanek
Date: Thu Sep 23 2004 - 05:40:08 EST


On Thu, Sep 23, 2004 at 03:14:51AM -0700, Andrew Morton wrote:
> Lukas Hejtmanek <xhejtman@xxxxxxxxxxxx> wrote:
> >
> > Sep 23 11:26:24 debian kernel: EIP: 0060:[fn_hash_insert+1039/1159] Tainted: P VLI
> >
>
> This might fix it
>
> --- a/net/ipv4/fib_hash.c 2004-09-23 03:13:49 -07:00
> +++ b/net/ipv4/fib_hash.c 2004-09-23 03:13:49 -07:00
> @@ -536,7 +536,7 @@
> * information.
> */
> fa_orig = fa;
> - list_for_each_entry(fa, fa->fa_list.prev, fa_list) {
> + list_for_each_entry(fa, fa_orig->fa_list.prev, fa_list) {
> if (fa->fa_info->fib_priority != fi->fib_priority)
> break;
> if (fa->fa_type == type &&

It has fixed it.

However there is still the issue with endless loop in fn_hash_delete :(

--
Lukáš Hejtmánek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/