Re: Is there a user space pci rescan method?

[Rolf Eike Beer]

Am Freitag, 24. September 2004 14:40 schrieben Sie:
> Rolf Eike Beer wrote:
> > -changed param "usedonly" to "showunused" so it behaves like fakephp at
> > the first look: if you load dummyphp without parameters there are only
> > slots with devices in it.
>
> Well, know I get only entries for all devices I don't have!

There was a device mask but I decided this was too ugly and ripped it out. 
Maybe it would make sense to have a parameter with an array of buses you want 
to see completely or something like this.

> > + dslot->dev = pci_get_slot(dslot->bus, dslot->devfn);
> > +
> > + if (showunused || dslot->dev) {
> > +  retval = 0;
> > +  goto error_dslot;
> > + }
>
> This should probably be !showunused || !dslot->dev ?

Yes. Error in boolean simplification.

Eike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/