Re: PATCH: (Test) it8212 driver for 2.6.9rc3

From: Alan Cox
Date: Thu Sep 30 2004 - 16:36:53 EST


On Thu, Sep 30, 2004 at 10:45:18PM +0200, Bartlomiej Zolnierkiewicz wrote:
> - merge+describe needed IDE core changes

Happily. I'm of the opinion the "ident whacking" callback isnt justified,
only one driver has a need for it and that driver can do it in the iops hook.

> - fix coding style and whitespace damage

Yeah

> - kill useless DECLARE_ITE_DEV macro

I'd prefer to keep it (there are likely to be some related devices from
the databook)

> - add __init to it8212_ide_init()

Good point - will fix

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/