Re: [PATCH] add hook for PCI resource deallocation

From: Ashok Raj
Date: Thu Sep 30 2004 - 17:22:32 EST


On Thu, Sep 30, 2004 at 02:50:14PM -0700, Andrew Morton wrote:
> Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx> wrote:
> >
> > I'm attaching updated patches for adding pcibiod_disable_device()
> > hook based on the feedback from Ashok (Thank you, Ashok!).
>
> This appears to be a patch-reversed version of the patch which is already
> in -mm:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.9-rc2/2.6.9-rc2-mm4/broken-out/add-hook-for-pci-resource-deallocation.patch
>
> So I'm not sure what you're trying to do here.


In the original patch, Kenji added a dummy function in several source files. Instead now
the new patch should have a single default implementation with a __attribute__((weak))

As a result its removing all the old additions and now keeping just a single default function.

so yes, its a reverse patch mostly, but there should also be a new function added with the weak
attribute.
--
Cheers,
Ashok Raj
- Linux OS & Technology Team
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/