Re: bug in sched.c:activate_task()

From: Ingo Molnar
Date: Tue Oct 05 2004 - 01:56:44 EST



On Tue, 5 Oct 2004, Con Kolivas wrote:

> unsigned long long delta = now - next->timestamp;
>
> if (next->activated == 1)
> delta = delta * (ON_RUNQUEUE_WEIGHT * 128 / 100) / 128;
>
> is in schedule() before we update the timestamp, no?

indeed ... so the patch is just random incorrect damage that happened to
distrub the scheduler fixing some balancing problem. Kenneth, what
precisely is the balancing problem you are seeing?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/