Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3

[James Bottomley]

On Fri, 2004-10-08 at 10:38, Mark Lord wrote:
> Can deadlock occur here, since qstor.c is already using schedule_work()
> as part of it's internal bottom-half handling for abnormal conditions?
> 
> Eg.  hotplug event -> schedule_work -> mid-layer -> queuecommand
>        --> sleep  :: interrupt -> schedule_work -> deadlock?
> 

Since you wouldn't go straight from schedule_work->mid-layer, I assume
you mean that when the workqueue thread runs the work?

With that assumption, this is legal and won't deadlock.

However, I assume you know you can't sleep in queuecommand since it may
be run from the scsi tasklet?

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/