[PATCH] Alpha - cpu mask fix-ups broke SMP DP264 machines in 2.6.8

From: Ali Saidi
Date: Fri Oct 08 2004 - 15:46:04 EST


The cpu mask fix-ups in 2.6.8 broke SMP kernels booting on a DP264. Instead of not setting the DIM for cpus that did not exit, the patch inadvertently doesn't set the DIM for CPUs that do exist. Thus no device interrupts get to the cpu.

Thanks,

Ali


--- linux-2.6.8.1.orig/arch/alpha/kernel/sys_dp264.c 2004-10-08 15:51:26.000000000 -0400
+++ linux-2.6.8.1.fix/arch/alpha/kernel/sys_dp264.c 2004-10-08 15:58:07.000000000 -0400
@@ -71,10 +71,10 @@
dim1 = &cchip->dim1.csr;
dim2 = &cchip->dim2.csr;
dim3 = &cchip->dim3.csr;
- if (cpu_possible(0)) dim0 = &dummy;
- if (cpu_possible(1)) dim1 = &dummy;
- if (cpu_possible(2)) dim2 = &dummy;
- if (cpu_possible(3)) dim3 = &dummy;
+ if (!cpu_possible(0)) dim0 = &dummy;
+ if (!cpu_possible(1)) dim1 = &dummy;
+ if (!cpu_possible(2)) dim2 = &dummy;
+ if (!cpu_possible(3)) dim3 = &dummy;

*dim0 = mask0;
*dim1 = mask1;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/