RE: promise controller resource alloc problems with ~2.6.8

[Li, Shaohua]

>On Thu, Sep 30, 2004 at 04:56:21PM -0700, Linus Torvalds wrote:
>> Now, the reason for using "insert_resource()" in arch/i386/pci/i386.c
>> should go away with Shaohua Li's patch, so I'd love to hear if
applying
>> Li's patch _and_ making the "insert_resource()" be a
"request_resource()"
>> fixes the problem for you.
>
>You meant this, right?
>
>if (!pr || insert_resource(pr, r) < 0)
>	printk(KERN_ERR "PCI: Cannot allocate resource region %d of
bridge
 
^^^^^^^^^
>%s\n", idx, pci_name(dev));
I go through the thread again and I guess you changed the wrong place. 
in line 114:
				if (!pr || request_resource(pr, r) < 0)
					printk(KERN_ERR "PCI: Cannot
allocate resource region %d of bridge %s\n", idx, pci_name(dev));

In line 145:
		if (!pr || insert_resource(pr, r) < 0) {
					printk(KERN_ERR "PCI: Cannot
allocate resource region %d of device %s\n", idx, pci_name(dev));
Please don't touch line 114, and change 'insert_resource' to '
request_resource' in line 145. Sorry for my bad mail client.

Thanks,
Shaohua
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/