Re: Totally broken PCI PM calls

From: Benjamin Herrenschmidt
Date: Mon Oct 11 2004 - 05:57:29 EST


On Mon, 2004-10-11 at 20:18, Pavel Machek wrote:
> Hi!
>
> > > Maybe the real problem is that we are trying to use the device suspend
> > > functions for suspend-to-disk, when we don't really want to change the
> > > device's power state at all.
> >
> > An acceptable solution is certainly to instead of passing down "go to D3",
> > just not do anything at all. HOWEVER, I doubt that is actually all that
> > good a solution either: devices quite possibly do want to save state
> > and/or set wake-on-events.
>
> And DMA needs to be stopped, or it is "bye bye data" situation.

This is true for pretty much any PM state

> Does sparse now have typechecking on enums? Solution that was in -mm
> was basically "put enums there so drivers can't be confused" + "signal
> global state out-of-band in global variable". It was not too nice, but
> it certainly was working.
> Pavel
--
Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/