Re: 2.6.9-rc4-mm1 HPET compile problems on AMD64

From: Badari Pulavarty
Date: Mon Oct 11 2004 - 16:55:37 EST


On Mon, 2004-10-11 at 14:25, Andi Kleen wrote:
> On Mon, Oct 11, 2004 at 01:26:53PM -0700, Badari Pulavarty wrote:
> > On Mon, 2004-10-11 at 12:54, Andrew Morton wrote:
> >
> > >
> > > I assume you have CONFIG_HPET=n and CONFIG_HPET_TIMER=n?
> > >
> > > Andi, what's going on here? Should the hpet functions in
> > > arch/x86_64/kernel/time.c be inside CONFIG_HPET_TIMER?
> >
> > I haven't enable HPET, but autoconf.h gets
> >
> > # grep HPET autoconf.h
> > #define CONFIG_HPET_TIMER 1
> > #define CONFIG_HPET_EMULATE_RTC 1
> >
> > # grep HPET .config
> > # CONFIG_HPET is not set
>
> It should be inside CONFIG_HPET. Badari's patch was correct.

make clean and oldconfig cleaned up little, but I still get
following linking error (without my patch).

# grep HPET .config
# CONFIG_HPET is not set

# grep HPET autoconf.h
#undef CONFIG_HPET

LD .tmp_vmlinux1
arch/x86_64/kernel/built-in.o(.init.text+0x2071): In function
`late_hpet_init':
arch/x86_64/kernel/entry.S:259: undefined reference to `hpet_alloc'

Andi, one thing I am not sure is - do you want entire routine
late_hpet_init() under CONFIG_HPET or only parts of it ?

Thanks,
Badari

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/