Re: Fw: signed kernel modules?

From: Rusty Russell (IBM)
Date: Wed Oct 13 2004 - 17:45:16 EST


On Wed, 2004-10-13 at 20:42, Alan Cox wrote:
> On Mer, 2004-10-13 at 01:11, Rusty Russell (IBM) wrote:
> > + unsigned long len,
> > + unsigned long offset,
> > + unsigned long elemsize,
> > + unsigned long num)
> > +{
> > + /* We're careful with wrap here. */
> > + if (offset > len)
> > + return 0;
> > + if (elemsize * num / num != elemsize)
>
> Whoops bang "num 0 elements". That check set isn't safe standalone

Thanks, Alan.

I'd appreciate your opinion on the issue at hand. Is it worth 600 lines
of ELF verification and canonicalization code so we can strip modules
without altering the signature?

Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/