Re: [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U5

From: Ingo Molnar
Date: Tue Oct 19 2004 - 06:45:48 EST



* Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> + * Wait for the lockd process to start, but since we're holding
> + * the lockd semaphore, we can't wait around forever ...
> + */
> + if (wait_event_interruptible_timeout(lockd_start,
> + nlmsvc_pid != 0, HZ)) {
> + printk(KERN_WARNING
> + "lockd_down: lockd failed to start\n");

yeah, this is much cleaner. I'd suggest to remove the init_sem() hack
from lib/rwsem-generic.c, it seems it is a nice facility to find
semaphore abuses.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/