Re: New consolidate irqs vs . probe_irq_*()

[Benjamin Herrenschmidt]

On Wed, 2004-10-20 at 19:20, Ingo Molnar wrote:
>
> .../...
>
> this is not a concept that would be too useful for the server space, but
> it sure could be useful for the produce-and-forget PC mass-market. We
> are playing a constant and mostly losing catchup game with BIOS quirks.
> 
> what can never work fully reliably is of course what the feature was
> used for primarily: ISA :-) One-time edge-triggered interrupts that get
> lost are nasty ...
> 
> so i thought autodetect.c could survive in the generic code - maybe we
> can make something really nice out of it, based on Alan's patch.

Hrm... Okay, maybe, but I'd rather keep it disabled for now on ppc and
ppc64, there is simply no case there where the interrupt informations
are incorrect :) And the way PCMCIA uses it is a bit nasty imho, besides
the current interface passing in a mask isn't really useable when your
max interrupt number goes beyond the size of a long.

Note that the reason why it dies on ppc atm is that it calls the irq
desc functions like shutdown() without testing if they exist in the
first place...

Looking at the code, it seems that I need to add startup() & shutdown()
callbacks to all my irq controllers so they do the equivalent of enable
and disable at least ...

Ben. 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/