Re: [PATCH] include all vmas with unbacked pages in ELF core dumps

[Roland McGrath]

> Augh. Not all filesystems support holes, 

We could represent the holes in ELF format instead.  When a hole is at the
tail end of a vma, just reducing p_memsz does the trick.  For holes in the
middle, we can make more ELF phdrs rather than one per vma.

> and I think VM_SHARED should trump VM_WRITE.

If VM_SHARED is never set when COW could have happened, then fine.

> But any non-dumped section _will_ show up in the ELF headers, so things
> like guard pages have nothing to do with "maydump()", imho. 

Guard pages are indeed not truly an interesting case, since they are always
zero anyway.  But in the general case, PROT_NONE is no guarantee that there
isn't worthwhile data there.  e.g., some GC schemes use page protections
temporarily on parts of their heap--if it crashes in the middle of that,
you want that heap page's contents dumped even though at that instant the
page was not readable.

> In general, I'd much prefer just adding a VM_DIRTY flag, and making the
> COW logic set it. That should guarantee that we write out the minimal 
> required sections.

I got the impression that vma->anon_vma being set when vma->vm_file is also
set means that COW happened.  Would VM_DIRTY not be set in the same set of
cases?


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/