Re: Am I paranoid or is everyone out to break my kernel builds (Breakage in drivers/pcmcia)

From: Russell King
Date: Thu Oct 21 2004 - 06:43:43 EST


On Thu, Oct 21, 2004 at 02:31:35AM -0700, Andrew Morton wrote:
> Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> wrote:
> > Take special note of the '&' before 'num' in the above initialiser, and
> > check the structure:
>
> Something's out of whack with your tree. You should have:

Ok, but what's the point of the change? If it's to indicate that
we're returning a value, shouldn't the other module_param* macros
also be fixed in the same way, or do we just like special cases?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/