Re: [PATCH] ppc: fix build with O=$(output_dir)

[Tom Rini]

On Thu, Oct 21, 2004 at 05:56:14PM +0000, roland@xxxxxxxxxxx wrote:
> ChangeSet 1.2040, 2004/10/21 10:56:14-07:00, roland@xxxxxxxxxxx
> 
> 	[PATCH] ppc: fix build with O=$(output_dir)
> 	
> 	Recent changes to arch/ppc/boot/lib/Makefile cause
> 	
> 	      CC      arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o
> 	    Assembler messages:
> 	    FATAL: can't create arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o: No such file or directory
> 	
> 	when building a ppc kernel using O=$(output_dir) with CONFIG_ZLIB_INFLATE=n,
> 	because the $(output_dir)/lib/zlib_inflate directory doesn't get created.
> 	
> 	This patch, which makes arch/ppc/boot/lib/Makefile create the
> 	directory if needed, is one fix for the problem.
> 	
> 	Signed-off-by: Roland Dreier <roland@xxxxxxxxxxx>
> 	Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
> 	Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>

Can we back this out please?  As I noted on lkml once I saw this, it
still doesn't fix the problem of overwriting files in lib/zlib_inflate/
if ZLIB_INFLATE!=n, and adding explicit rules for lib/zlib_inflate/foo.c
-> ./foo.o looks quite bad (it's 2 calls if we want checker to get
invoked, one if we skip doing that).  At the end of the thread, both
Roland and I were hoping Sam knew of a clever solution to this.

-- 
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/