Re: [PATCH] ppc: fix build with O=$(output_dir)

From: Roland Dreier
Date: Thu Oct 21 2004 - 23:33:29 EST


Tom> Can we back this out please? As I noted on lkml once I saw
Tom> this, it still doesn't fix the problem of overwriting files
Tom> in lib/zlib_inflate/ if ZLIB_INFLATE!=n, and adding explicit
Tom> rules for lib/zlib_inflate/foo.c
-> ./foo.o looks quite bad (it's 2 calls if we want checker to get
Tom> invoked, one if we skip doing that). At the end of the
Tom> thread, both Roland and I were hoping Sam knew of a clever
Tom> solution to this.

I can't really object to backing this out, but I'll just point out
that without this patch, in the situations where mainline builds at
all, it still overwrites files in lib/zlib_inflate/. (And builds with
O=xxx don't work at all)

It might make more sense to leave this patch in for now and beg Sam
for a better fix in the future.

Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/