Re: [patch 1/1] dm: fix printk errors about whether %lu/%Lu isright for sector_t - revised

From: Andrew Morton
Date: Fri Oct 22 2004 - 04:59:59 EST


blaisorblade_spam@xxxxxxxx wrote:
>
> The Device Manager code barfs when sector_t is 64bit wide (i.e. an u64) and
> CONFIG_LBD is off. This happens on printk(), resulting in wrong memory
> accesses, but also on sscanf(), resulting in overflows (because it uses %lu
> for a long long in this case). And region_t, chunk_t are typedefs for
> sector_t, so we have warnings for these, too.

This patch caused the x86_64 build to puke: "Not allowed to define
CONFIG_LBD on this architecture" or some such.

I'd much prefer that you simply remove SECTOR_FORMAT completely.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/