Re: [PATCH] delay rq_lock acquisition in setscheduler

From: Ingo Molnar
Date: Sat Oct 23 2004 - 05:49:25 EST



* Chris Wright <chrisw@xxxxxxxx> wrote:

> Doing access control checks with rq_lock held can cause deadlock when
> audit messages are created (via printk or audit infrastructure) which
> trigger a wakeup and deadlock, as noted by both SELinux and SubDomain
> folks. This patch will let the security checks happen w/out lock held,
> then re-sample the p->policy in case it was raced. Originally from John
> Johansen <johansen@xxxxxxxxxxx>, reworked by me. AFAIK, this version
> drew no objections from Ingo or Andrea. Please let me know if there's
> any issue with the patch.
>
> From: John Johansen <johansen@xxxxxxxxxxx>
> Signed-off-by: Chris Wright <chrisw@xxxxxxxx>

Acked-by: Ingo Molnar <mingo@xxxxxxx>

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/