Re: [PATCH} Trivial - fix drm_agp symbol export

[Christoph Hellwig]

On Sun, Oct 24, 2004 at 12:28:18AM +1000, Dave Airlie wrote:
> > 
> > Sorry, wrong API.  At least export the individual functions and use them
> > directly (and without the symbol_get abnomination that's not any better
> > than inter_module_*).
> 
> I wonder what the reasoning behind the old drm_agp structure was in
> the first place?
> 
> What about this patch?

The patch looks good to me, I really like the reduced complexity.

Some minor nitpicks below:

+	if (!(head = DRM(alloc)(sizeof(*head), DRM_MEM_AGPLISTS)))
+		return NULL;
+	memset((void *)head, 0, sizeof(*head));

no need to cast to void * here

@@ -428,41 +409,37 @@
  */
 void DRM(agp_uninit)(void)
 {
-	DRM_AGP_PUT;
-	drm_agp = NULL;
 }

is the function needed by BSD?  Else it should probably go away completely.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/