Re: 2.6.9-rc4 No local APIC present or hardware disabled

[Alan Cox]

On Sul, 2004-10-24 at 16:44, Maciej W. Rozycki wrote:
> > I agree with Alan that accusing the BIOS of being buggy is unwarranted.
> 
>  I disagree.  If the firmware performs any actions on hardware without
> asking the OS for permission, it *must* be prepared for it to be in any
> possible state and handle it correctly, including any transitional states
> (as it does respect spinlocks).  Otherwise it's buggy.

Show me a PC standards document that says this - there are none.

>  Alan, referring to your statement: it's like stating we must only use the
> text mode of the display adapter, because that's the state it's left in by
> the firmware and it may not expect any other state.

If you switch video mode without using the BIOS then the BIOS video
calls are not guaranteed to work. Its the same thing.


> +		if (enable_local_apic <= 0) {
> +			apic_printk(APIC_VERBOSE,
> +				    "Local APIC disabled by BIOS -- "
> +				    "you can enable it with \"lapic\"\n");
> +			return -1;

Looks good to me in this form.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/