Re: [PATCH 1/2] delete_from_page_cache

[Hugh Dickins]

On Sun, 24 Oct 2004, Hugh Dickins wrote:

> Both reiser4 and cachefs want remove_from_page_cache to be exported.
> Before that, could we please make it symmetric with add_to_page_cache,
> add_to_swap_cache and delete_from_swap_cache? by doing its own
> page_cache_release, instead of commenting that each time it's called.
> But safer if we change the name too: delete_from_page_cache.
> 
> This patch is against 2.6.10-rc1, which doesn't include reiser4 and
> cachefs.  The next patch is against 2.6.9-mm1 and patches those.
> But I can understand if you ignore both patches as a waste of time.

I apologize, yes, a waste of time.  A good idea a year or few ago,
but now too late.  Reiser4's drop_page has to unlock the page between
removing it from page cache and doing the page_cache_release - as it
correctly did before my patches interfered.  And it would be highly
inappropriate for me to be forcing reiser4 to do this some other way.
So, sorry, please just ignore/revert my delete_from_page_cache patches.

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/