Re: Problem with module parameters and sysfs

[Dominik Brodowski]

On Wed, Oct 27, 2004 at 01:43:54AM -0500, Dmitry Torokhov wrote:
> Hi,
> 
> It seems that the following patch
> 
> http://linux.bkbits.net:8080/linux-2.5/diffs/kernel/params.c%401.12?nav=index.html|ChangeSet@-3d|cset@xxxxxx
> 
> broke module parameters in sysfs for the case when driver is built
> as a module:
> 
> [root@core dtor]# ls -la /sys/module/i8042/
> total 0
> drwxr-xr-x    3 root     root            0 Oct 26 19:20 .
> drwxr-xr-x   54 root     root            0 Oct 27 00:28 ..
> drwxr-xr-x    2 root     root            0 Oct 26 19:20 parameters
> 
> [root@core dtor]# ls -la /sys/module/psmouse/
> total 0
> drwxr-xr-x    3 root     root            0 Oct 27 00:21 .
> drwxr-xr-x   54 root     root            0 Oct 27 00:28 ..
> -r--r--r--    1 root     root         4096 Oct 27 00:21 refcnt
> drwxr-xr-x    2 root     root            0 Oct 27 00:21 sections
> 
> psmouse is built as a module while i8042 is compiled in.

All module_params I can see in psmouse have permission "0", so they don't
need to be exported in sysfs. Or am I missing something here?

Thanks,
	Dominik
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/