Re: RFC: Changes to fs/buffer.c?

From: Linus Torvalds
Date: Fri Oct 29 2004 - 16:17:37 EST




On Fri, 29 Oct 2004, Andrew Morton wrote:
>
> Anton Altaparmakov <aia21@xxxxxxxxx> wrote:
> >
> > Is it ok to export
> > create_buffers() and to make __set_page_buffers() static inline and move
> > it to include/linux/buffer.h?
>
> ho, hum - if you must ;)
>
> I'd be inclined to rename it to attach_page_buffers() or something though -
> create_buffers() is a bit generic-sounding.

Also, I think we should at least start out limiting it to GPL-only usage.
Those page buffers are pretty intertwined with the VM usage, I'd hate to
see people think this is some kind of external interface..

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/