Re: net: generic netdev_ioaddr

[Pekka J Enberg]

Hi, 

Al Viro writes:
> NAK.  ->base_addr casting is a Bad Idea(tm) and natsemi "solution" isn't
> (thanks for spotting that crap in natsemi, though; will fix...) 
>
> Note that there is no such thing as "generic IO base address" - it _is_
> private and in the best case current ->base_addr is a scratch register
> probably used for something vaguely connected with some IO, but it's
> really up to driver...

Yup, I thought about that after I sent the patch. However, as it stands now, 
many network drivers use netdev->base_addr for just that.  Perhaps it should 
be nuked completely instead? 

           Pekka 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/