Re: [PATCH 475] HP300 LANCE

[Chuck Ebbert]

On Sun, 31 Oct 2004 at 02:48:40 -0800 Andrew Morton <akpm@xxxxxxxx> wrote:

> It comes out visually OK once the patch is applied.  But it's a
> useful reminder of how much dreck we have in the tree.

That's for sure:

[me@nb linux-2.6.9]$ find . -name "*.[ch]" | xargs egrep -H -n '^[[:space:]]+if\(' | \
> tee if_should_be_followed_by_space | wc -l
18991


And my favorite pet peeve:

[me@nb linux-2.6.9]$ find . -name "*.[ch]" | \
> xargs egrep -H -n '^[[:space:]]+return[[:space:]]*\([^)]+\);' | \
> tee return_is_not_a_function | wc -l
9867

There are a lot more than that but I could find no obvious way of including
"return(parenthesized expr)" while excluding "return (typecast)(expr)".


--Chuck Ebbert  31-Oct-04  23:46:37
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/