Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include

[Chuck Ebbert]

Linus Torvalds wrote:
> 
> This one is _totally_ broken. 
> 
> Not only is that include not recursive, but it immediately breaks any SMP 
> compile because that header file _needs_ the definition of "task_struct".
>
>
> On Sun, 31 Oct 2004, Geert Uytterhoeven wrote:
> >
> > smp_lock.h: Avoid recursive include
> > 
> > --- linux-2.6.10-rc1/include/linux/smp_lock.h       2004-04-28 15:47:31.000000000 +0200
> > +++ linux-m68k-2.6.10-rc1/include/linux/smp_lock.h  2004-10-20 22:24:05.000000000 +0200
> > @@ -2,7 +2,6 @@
> >  #define __LINUX_SMPLOCK_H
> >  
> >  #include <linux/config.h>
> > -#include <linux/sched.h>


Shouldn't you also revert cset 1.2405, also by Geert, which added
<linux/sched.h> to reiserfs_fs.h?  Looks like that was done to fix
breakage caused by this change.


--Chuck Ebbert  02-Nov-04  03:48:03
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/